Skip to content

Pin Windows-compatible version of Task where necessary #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Pin Windows-compatible version of Task where necessary #185

merged 1 commit into from
Nov 30, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 30, 2021

The recent 3.9.1 release of the Task task runner does not correctly handle the PATH environment variable on Windows.
Since the "template" workflows were configured to always use the latest version of Task within the 3.x major version
series, this bug caused spurious failure of workflows under the following conditions:

  • Used a Windows runner
  • Ran a task that contained a command reliant on a file from PATH

(example)

The workaround is to pin the version of Task used in these workflows to the last working version: 3.9.0.

The recent 3.9.1 release of the Task task runner does not correctly handle the PATH environment variable on Windows.
Since the "template" workflows were configured to always use the latest version of Task within the 3.x major version
series, this bug caused spurious failure of workflows under the following conditions:

- Used a Windows runner
- Ran a task that contained a command reliant on a file from PATH

The workaround is to pin the version of Task used in these workflows to the last working version: 3.9.0.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Nov 30, 2021
@per1234 per1234 requested a review from umbynos November 30, 2021 17:06
@per1234 per1234 self-assigned this Nov 30, 2021
@per1234 per1234 merged commit f8b7164 into arduino:main Nov 30, 2021
@per1234 per1234 deleted the pin-task branch December 15, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants