Use shallow fetch for Go tester build #145
Merged
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior of the `actions/checkout` action is to do a shallow fetch of the repository, which is the most efficient if all that's needed is a copy of the repository files. In cases where the repository history is needed, this behavior is not appropriate, and so it can be configured via the `fetch-depth` input. Setting this input to 0 causes the full history to be fetched. A full fetch is required for workflows that use the `arduino/create-changelog` action to generate a raw changelog from the commit history, and so it is found in the "Release" workflow. However, there is no use of the commit history by the "Publish Tester Build" workflow, which does not need a changelog. The unnecessary full fetch makes the workflow less efficient and more difficult to understand, so it must be removed.
per1234
added
type: imperfection
umbynos
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of the
actions/checkoutaction is to do a shallow fetch of the repository, which is the most efficient if all that's needed is a copy of the repository files. In cases where the repository history is needed, this behavior is not appropriate, and so it can be configured via thefetch-depthinput. Setting this input to 0 causes the full history to be fetched.A full fetch is required for workflows that use the
arduino/create-changelogaction to generate a raw changelog from the commit history, and so it is found in the "Release" workflow. However, there is no use of the commit history by the "Publish Tester Build" workflow, which does not need a changelog.The unnecessary full fetch makes the workflow less efficient and more difficult to understand, so it must be removed.
Demo workflow run after this change: https://github.com/per1234/arduino-lint/actions/runs/1133921362