Use taskfile variable to define primary Go module path #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although support was added to the Go module related "templates" for projects which contain modules at other paths, the assumption remained that there will always be a primary module in the root of the repository, and this path was hardcoded at several locations in the taskfiles. It might be that a project that is not a Go module contains an accessory Go module in a subfolder. In this case, the use of a taskfile variable will allow that path to be defined in one place, avoiding the need to override the hardcoded incorrect location whenever a Go module-related task is run manually.
per1234
added
topic: code
umbynos
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although support was added to the Go module related "templates" for projects which contain modules at other paths (#136), the assumption remained that there will always be a primary module in the root of the repository, and this path was hardcoded at several locations in the taskfiles.
It might be that a project that is not a Go module contains an accessory Go module in a subfolder (example). In this case, the use
of a taskfile variable will allow that path to be defined in one place, avoiding the need to override the hardcoded incorrect location whenever a Go module-related task is run manually.