Skip to content

Add template workflow to validate Taskfiles #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 15, 2021

On every push or pull request that affects the repository's Taskfiles, and periodically, validate them against the JSON schema.

I decided against the usual Task-based approach for this particular workflow because it seems problematic to use a task to validate the Taskfile that defines the task. If the Taskfile was invalid, then the task to validate it likely wouldn't run anyway. I think this is the sort of thing like the license check where you throw the workflow into the repository and forget about it until such time as someone mucks up the file it watches, when it comes to life and saves the day.

The workflow is also used in this repository's own CI. Due to the need to customize the template workflow

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 15, 2021
@per1234 per1234 requested review from silvanocerza and rsora June 15, 2021 14:25
On every push or pull request that affects the repository's Taskfiles, and periodically, validate them
against the JSON schema.
@per1234 per1234 merged commit 27e0b6a into main Jun 15, 2021
@per1234 per1234 deleted the check-taskfiles branch June 15, 2021 15:05
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants