"Template" installation script does not consider M1 compatibility via Rosetta 2

[per1234]

This repository contains a "template" installation script that can provide a convenient installation option for any application that publishes builds via GitHub releases:

https://github.com/arduino/tooling-project-assets/tree/main/other/installation-script

This script automatically detects the host system OS and architecture and downloads the appropriate release file based on this.

Apple's Rosetta 2 software allows applications built for x86-64 hosts to run on machines using their ARM 64-bit M1 processor.

Due to current infrastructure challenges (e.g., lack of GitHub-hosted GitHub Actions runners), Arduino's applications may not yet be available as native M1 builds, yet the existing macOS x86-64 builds work perfectly well on these machines thanks to Rosetta 2.

The installation script currently fails to install these applications:

Did not find a release for your system: macOS arm64

This will cause prospective users to mistakenly think that the application is not available for their system.

To do

• Adjust the script so that it will use the "macOS_64bit" download if "macOS_arm64" is not found.
• Update the downstream copies of the script:
  • https://github.com/arduino/arduino-cli/blob/master/install.sh
  • https://github.com/arduino/arduino-lint/blob/main/etc/install.sh

Related

Also reported at:

• Add native support for Apple Silicon arduino-cli#1313 (comment)
• Feature request: Support macOS arm64 arduino-lint#348
• Installation script's github downloader blows up due to shell line length issue on macos 12.3 arduino-cli#1714

[per1234]

From arduino/arduino-cli#1714 (comment) by @obra

There's a pretty straightforward change that would work for the arduino-cli implementation, although it might not be fully portable to other places arduino uses this script. You don't need to parse the releases page, since the release urls are easily predictable.

   # Support specifying nightly build versions (e.g., "nightly-latest") via the script argument.
   case "$TAG" in
   nightly*)
     DOWNLOAD_URL="https://downloads.arduino.cc/${PROJECT_NAME}/nightly/${APPLICATION_DIST}"
     ;;
   *)
     DOWNLOAD_URL="https://downloads.arduino.cc/${PROJECT_NAME}/${APPLICATION_DIST}"
    
 +GITHUB_TAG_DOWNLOAD_URL="https://github.com/arduino/${PROJECT_NAME}/releases/download/${TAG}/${PROJECT_NAME}/${APPLICATION_DIST}"
     ;;
   esac
 
   INSTALLATION_TMP_FILE="/tmp/$APPLICATION_DIST"
   echo "Downloading $DOWNLOAD_URL"
   httpStatusCode=$(getFile "$DOWNLOAD_URL" "$INSTALLATION_TMP_FILE")
   if [ "$httpStatusCode" -ne 200 ]; then
+    echo "Did not find a release for your system published on downloads.arduino.cc: $OS $ARCH"
+   echo "Trying to find a release from the GitHub releases page."
+   httpStatusCode=$(getFile "$GITHUB_TAG_DOWNLOAD_URL" "$INSTALLATION_TMP_FILE")