Skip to content

Use ncc to compile the action #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatteoPologruto
Copy link
Contributor

Switching to ncc to compile the action allows the removal of node_modules from the repository.
This was done for other actions like arduino/setup-task, arduino/create-changelog and arduino/arduino-lint-action.

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels May 24, 2023
@MatteoPologruto MatteoPologruto self-assigned this May 24, 2023
@MatteoPologruto MatteoPologruto marked this pull request as ready for review May 24, 2023 14:13
@MatteoPologruto MatteoPologruto force-pushed the switch-to-ncc-packaging branch from 7f329a2 to f807b1e Compare May 24, 2023 15:00
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the test-integration.yml workflow events from:
- "lib/**" to - "dist/**"

@MatteoPologruto MatteoPologruto force-pushed the switch-to-ncc-packaging branch from 0250ef1 to 186b8dd Compare May 29, 2023 07:23
@MatteoPologruto MatteoPologruto force-pushed the switch-to-ncc-packaging branch from 186b8dd to 1b412c9 Compare May 29, 2023 07:26
@MatteoPologruto MatteoPologruto merged commit 0fb3d10 into arduino:master May 29, 2023
@MatteoPologruto MatteoPologruto deleted the switch-to-ncc-packaging branch May 29, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants