Skip to content

Resolve ts:lint errors #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 29, 2023
Merged

Resolve ts:lint errors #74

merged 8 commits into from
May 29, 2023

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented May 23, 2023 •
edited
Loading

Resolve errors highlighted by ts:lint, following these steps:

  • add auto-generated code (dist, lib and node_modules) to .eslintignore
  • ignore @typescript/no-use-before-define errors
  • add typed-rest-client and @actions/io to the project's dependencies (required by ESLint)
  • run ts:lint-fix and manually resolve leftover errors
  • build the action

@MatteoPologruto MatteoPologruto added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 23, 2023
@MatteoPologruto MatteoPologruto self-assigned this May 23, 2023
@alessio-perugini alessio-perugini linked an issue May 24, 2023 that may be closed by this pull request
Stop ignoring ts lint in CI #70
Closed
3 tasks
alessio-perugini
alessio-perugini approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatteoPologruto MatteoPologruto merged commit de6caf7 into arduino:master May 29, 2023
@MatteoPologruto MatteoPologruto deleted the resolve-lint-errors branch May 29, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@per1234 per1234 Awaiting requested review from per1234

@umbynos umbynos Awaiting requested review from umbynos

Assignees

@MatteoPologruto MatteoPologruto

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop ignoring ts lint in CI
2 participants
@MatteoPologruto @alessio-perugini