Update Keyboard documentation #878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Keyboard documentation to include other non-ascii keys listed in Keyboard.h https://github.com/arduino-libraries/Keyboard/blob/master/src/Keyboard.h
|
|
|
Ah, It appears as if the changes I'm documenting have not yet been released. I guess I should close this for now? |
|
Thanks @NicBallinger. The changes you proposed here have now been made via #881. I really appreciate your care for keeping this important documentation up to date. For future reference, there is no problem with submitting a pull request here for changes related to unreleased code. You are correct that we should not merge the pull requests until the release happens, but getting prepared for the release in advance is always a good thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Keyboard documentation to include other non-ascii keys listed in Keyboard.h
This is a minimalistic change. Breaking the table apart to better match the source may make the documentation more useful.
Adding a link to the definitions in Keyboard.h would may the page more pedagogical.
But those are just suggestions.
The source for Keyboard.h is located here.
https://github.com/arduino-libraries/Keyboard/blob/master/src/Keyboard.h