Skip to content

Include Nano 33 and Portenta #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2020
Merged

Include Nano 33 and Portenta #791

merged 5 commits into from
Oct 21, 2020

Conversation

ubidefeo
Copy link
Contributor

These boards are lacking in this piece of documentation, possibly elsewhere

These boards are lacking in this piece of documentation, possibly elsewhere
subCategories: [ "Zero, Due & MKR Family" ]
subCategories: [ "Zero, Due, MKR family, Nano 33 (BLE and IoT) and Portenta" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause the page to no longer be published at https://www.arduino.cc/reference/en/:


VirtualBox_Ubuntu_20_10_2020_16_58_01


The reason is because no subcategory of this name has been defined. One could be defined, but I think it's not a sustainable strategy to continuously append board names as needed.

Better would be to change to a non-board specific category name. I would prefer to just move the analogReadResolution() and analogWriteResolution() reference pages to the "Analog I/O" subcategory, then make sure the reference pages are very clear about which boards support these functions.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes a lot of sense, Per
I don't know how such content is organised, and I'm glad you posted your feedback 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the category change and will post it as another PR

ubidefeo and others added 4 commits October 21, 2020 07:24
…adoc

Co-authored-by: per1234 <accounts@perglass.com>
…adoc


Yes!
I just discovered that such method is not available and throws an error.
I believe it should be added to cores which do not support multiple resolutions, just in case a user obtains a sketch made on an *arm* board and the compilation error makes no sense to them.
The method could be just a sinkhole but would prevent the compile error :)

Co-authored-by: per1234 <accounts@perglass.com>
In order to submit a new PR with just the category change
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @ubidefeo!

@per1234 per1234 merged commit 5c6f13a into arduino:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants