Update volatile.adoc: Add explanation to examples #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also adds a visual separator between the two code blocks so it is clear that they do not belong together.
per1234
requested changes
Dec 1, 2019
Language/Variables/Variable Scope & Qualifiers/volatile.adoc
Outdated
Show resolved
Hide resolved
Language/Variables/Variable Scope & Qualifiers/volatile.adoc
Outdated
Show resolved
Hide resolved
Language/Variables/Variable Scope & Qualifiers/volatile.adoc
Outdated
Show resolved
Hide resolved
|
Hi @per1234, thanks a lot for your review and sorry for the bad quality of the MR. I was too much in a rush. Will improve it, but it is going to take a few days :) |
|
@per1234 Any comments on the updated docs? |
|
@per1234 ping. Can this MR be merged? Any open issues? |
|
Guys, this PR is more than 1.5 years old. Would really appreciate to get this forward a bit. @kengdahl could you help me on that maybe? |
cmaglie
requested changes
Sep 23, 2020
Language/Variables/Variable Scope & Qualifiers/volatile.adoc
Outdated
Show resolved
Hide resolved
Language/Variables/Variable Scope & Qualifiers/volatile.adoc
Outdated
Show resolved
Hide resolved
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also adds a visual separator between the two code blocks so it is clear that they do not belong together.