Skip to content

Update loop.adoc #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Update loop.adoc #302

merged 1 commit into from
Jan 19, 2018

Conversation

ZWahl
Copy link
Contributor

@ZWahl ZWahl commented Jan 17, 2018

There is a typo in lines 40, 49 and 51.

Line 40:
Was: beginSerial(9600);
Now: Serial.begin(9600);

Line 49:
Was: serialWrite('H');
Now: Serial.write('H');

Line 51:
Was: serialWrite('L');
Now: Serial.write('L');

After I made the above proposed changes, the syntax agreed with the existing documentation for "Serial.begin" and "Serial.write" and the little demo program started to work as expected.

Sincerely,
ZWahl

P.S. I'm new to this forum and Arduino. I tried the above program and had to debug and thought that correcting the "loop" example code would help another newcomer, so please advise on how to proceed to incorporate this change to the loop.adoc.

There is a typo in lines 40, 49 and 51.

Line 40:
Was: beginSerial(9600);
Now: Serial.begin(9600);

Line 49:
Was: serialWrite('H');
Now: Serial.write('H');

Line 51:
Was: serialWrite('L');
Now: Serial.write('L');

After I made the  above proposed changes, the syntax agreed with the existing documentation for "Serial.begin" and "Serial.write" and the little demo program started to work as expected.

Sincerely,
ZWahl
@per1234
Copy link
Collaborator

per1234 commented Jan 17, 2018

That's a very helpful contribution. Thanks!

please advise on how to proceed to incorporate this change to the loop.adoc

You've done everything correctly. Now you only need to wait for one of the administrators of this repository to merge your pull request. Some time after that the changes will be pushed to the reference pages on arduino.cc. So there's no further action required from you.

@ZWahl
Copy link
Contributor Author

ZWahl commented Jan 17, 2018 via email

@SimonePDA SimonePDA merged commit aa1904b into arduino:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants