Skip to content

QUIT command response is not specification compliant #13

Closed
@per1234

Description

@per1234

Describe the problem

The pluggable monitor specification states:

https://arduino.github.io/arduino-cli/dev/pluggable-monitor-specification/#quit-command

The QUIT command terminates the monitor. The response to QUIT is:

{
  "eventType": "quit",
  "message": "OK"
}

🐛 However, there is no response from the QUIT command.

To reproduce

$ git clone https://github.com/arduino/pluggable-monitor-protocol-handler

$ cd pluggable-monitor-protocol-handler/dummy-monitor/

$ git log -1 --oneline
3dee1f8 (HEAD -> main, origin/main, origin/HEAD) Merge pull request #12 from per1234/issue-forms

$ go build

$ ./dummy-monitor
QUIT

🐛 There is no response from the QUIT command.

Expected behavior

Response from QUIT command is specification compliant.

'github.com/arduino/pluggable-monitor-protocol-handler' version

3dee1f8

Additional context

The github.com/arduino/pluggable-discovery-protocol-handler module had the same bug, which was fixed by arduino/pluggable-discovery-protocol-handler#15

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest version
  • My report contains all necessary details

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions