Skip to content

I2C clock fix backport #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

pennam
Copy link

@pennam pennam commented Mar 29, 2021

Summary of changes

I've started testing Portenta breackout so i've backported ARMmbed#14030 to portenta-mbed-6.2.0 tu run Mbed ci I2C tests

Impact of changes

Migration actions required

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Mbed ci test shield test results on I2C1 (PB7,PB6) I2C3 (PH8, PH7) I2C4(PH12, PH11) are ok. Bootloader needed to enable internal 3.3V for I2C1 level shifter.

mbedgt: checking for GCOV data...
mbedgt: mbed-host-test-runner: stopped and returned 'OK'
mbedgt: test on hardware with target id: 002000423438510A34313939
mbedgt: test suite 'tests-api-i2c' ................................................................... OK in 14.45 sec
        test case: 'I2C -  EEProm 2nd WR 10  Bytes' .................................................. OK in 0.11 sec
        test case: 'I2C -  EEProm 2nd WR 100 Bytes' .................................................. OK in 0.22 sec
        test case: 'I2C -  EEProm 2nd WR 2 Bytes' .................................................... OK in 0.13 sec
        test case: 'I2C -  EEProm 2nd WR Single Byte' ................................................ OK in 0.12 sec
        test case: 'I2C -  EEProm WR 10  Bytes' ...................................................... OK in 0.12 sec
        test case: 'I2C -  EEProm WR 100 Bytes' ...................................................... OK in 0.22 sec
        test case: 'I2C -  EEProm WR 2 Bytes' ........................................................ OK in 0.11 sec
        test case: 'I2C -  EEProm WR Single Byte' .................................................... OK in 0.11 sec
        test case: 'I2C -  Instantiation of I2C Object' .............................................. OK in 0.08 sec
        test case: 'I2C -  LM75B Temperature Read' ................................................... OK in 0.09 sec
mbedgt: test case summary: 10 passes, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.9177220330
mbedgt: test suite report:
| target                 | platform_name  | test suite    | result | elapsed_time (sec) | copy_method |
|------------------------|----------------|---------------|--------|--------------------|-------------|
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | OK     | 14.45              | default     |
mbedgt: test suite results: 1 OK
mbedgt: test case report:
| target                 | platform_name  | test suite    | test case                          | passed | failed | result | elapsed_time (sec) |
|------------------------|----------------|---------------|------------------------------------|--------|--------|--------|--------------------|
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm 2nd WR 10  Bytes     | 1      | 0      | OK     | 0.11               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm 2nd WR 100 Bytes     | 1      | 0      | OK     | 0.22               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm 2nd WR 2 Bytes       | 1      | 0      | OK     | 0.13               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm 2nd WR Single Byte   | 1      | 0      | OK     | 0.12               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm WR 10  Bytes         | 1      | 0      | OK     | 0.12               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm WR 100 Bytes         | 1      | 0      | OK     | 0.22               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm WR 2 Bytes           | 1      | 0      | OK     | 0.11               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  EEProm WR Single Byte       | 1      | 0      | OK     | 0.11               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  Instantiation of I2C Object | 1      | 0      | OK     | 0.08               |
| PORTENTA_H7_M7-GCC_ARM | PORTENTA_H7_M7 | tests-api-i2c | I2C -  LM75B Temperature Read      | 1      | 0      | OK     | 0.09               |

Reviewers


@pennam pennam changed the title I2C clock fix I2C clock fix backport Mar 29, 2021
@pennam pennam marked this pull request as ready for review March 29, 2021 13:47
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@pennam
Copy link
Author

pennam commented Apr 13, 2021

closing since the new core is based on newer version of mbed and includes this changes.

@pennam pennam closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants