Skip to content

Update repositories.txt #6028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Update repositories.txt #6028

merged 4 commits into from
Mar 10, 2025

Conversation

Asyasyarif
Copy link
Contributor

Added our repo library.

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 9, 2025
Copy link
Contributor

github-actions bot commented Mar 9, 2025

A problem was found with your submission https://github.com/firmngin/kit

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @Asyasyarif
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

github-actions bot commented Mar 9, 2025

A problem was found with your submission https://github.com/firmngin/kit

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @Asyasyarif
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Asyasyarif. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/firmngin/kit/tree/0.0.1

(note there is no library.properties file at the tagged point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 self-assigned this Mar 9, 2025
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Mar 9, 2025
@Asyasyarif
Copy link
Contributor Author

Hi @per1234

I've been create a new tag & release.
added library.properties

Thanks

@Asyasyarif
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Mar 9, 2025
Copy link
Contributor

github-actions bot commented Mar 9, 2025

ERROR: Arduino Lint found errors with https://github.com/firmngin/kit:

Linting library in kit
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (firmnginKit.h). Best practices are for primary header filename to     
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties includes field item(s) firmnginKit.h not found in library.                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           kit/lib/firmnginKit/examples/BasicExample                                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @Asyasyarif
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Asyasyarif . Thanks for your interest in contributing to the Arduino Library Manager.

I see the bot reported a problem with your submission that will block its acceptance:

Linting library in kit
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           

The reason your library is not recognized as a valid Arduino library is because it is not a library, but instead a "PlatformIO" program. I do see that there is a library bundled with your program, under the lib/firmnginKit subfolder:

https://github.com/firmngin/kit/tree/main/lib/firmnginKit

In order to be included in the Arduino Library Manager, a library must be in the root of the repository, not under a subfolder. If you would like to add the library to Library Manager, you should move the contents of the lib/firmnginKit subfolder either up to the root of the firmngin/kit repository, or to a dedicated repository.

Please fix the problem so we can proceed with your submission.

If you have any questions or concerns, please let me know.

Regards, Per

@Asyasyarif
Copy link
Contributor Author

Hi @per1234

Done change folder style with standard Arduino Libs.
@ArduinoBot

Thanks

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Mar 9, 2025

ERROR: Arduino Lint found errors with https://github.com/firmngin/kit:

Linting library in kit
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (firmnginKit.h). Best practices are for primary header filename to     
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties includes field item(s) firmnginKit.h not found in library.                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           kit/lib/firmnginKit/examples/BasicExample                                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @Asyasyarif
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/firmngin/kit:

Linting library in kit
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (firmnginKit.h). Best practices are for primary header filename to     
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties includes field item(s) firmnginKit.h not found in library.                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           kit/lib/firmnginKit/examples/BasicExample                                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Asyasyarif
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Asyasyarif
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/firmngin/kit:

Linting library in firmnginKit
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (firmnginKit.h). Best practices are for primary header filename to     
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties includes field item(s) firmnginKit.h not found in library.                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           firmnginKit/lib/firmnginKit/examples/BasicExample                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @Asyasyarif
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot merged commit aa4777a into arduino:main Mar 10, 2025
11 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/firmngin/firmnginKit/

github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants