Skip to content

Update repositories.txt #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Update repositories.txt #4123

merged 2 commits into from
Feb 25, 2024

Conversation

IlikeChooros
Copy link
Contributor

No description provided.

Copy link
Contributor

A problem was found with your submission https://github.com/IlikeChooros/lazyjson

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions github-actions bot added the topic: submission Add library to the list label Feb 24, 2024
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @IlikeChooros
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@IlikeChooros
Copy link
Contributor Author

Idk what is wrong, I clearly have the mandatory file library.properties in the root of the project

@per1234 per1234 self-assigned this Feb 24, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @IlikeChooros. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/IlikeChooros/lazyjson/tree/v.1.0.0

(note there is no library.properties file at the tagged version of the repository)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@IlikeChooros
Copy link
Contributor Author

Thank you for your help, hopefully it will work now, @ArduinoBot

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 February 24, 2024 20:54
@github-actions github-actions bot removed the request for review from per1234 February 25, 2024 09:03
@github-actions github-actions bot merged commit 3681fba into arduino:main Feb 25, 2024
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/IlikeChooros/lazyjson/

github-actions bot pushed a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants