Skip to content

remove koendv/FloatToString #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024
Merged

remove koendv/FloatToString #4084

merged 1 commit into from
Feb 21, 2024

Conversation

koendv
Copy link
Contributor

@koendv koendv commented Feb 19, 2024

Copy link
Contributor

Hi @koendv.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: removal Remove library from the list label Feb 19, 2024
@github-actions github-actions bot requested a review from per1234 February 19, 2024 07:51
@per1234 per1234 mentioned this pull request Feb 19, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @koendv. I am confirming your request.


I really appreciate your care for fixing this semi-collision. We should probably adjust the submission checker system to detect this and block the submissions in order to ensure distinctive library names.


Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Feb 19, 2024
@MatteoPologruto MatteoPologruto self-assigned this Feb 21, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/02/21 16:09:09 Loaded 6678 libraries from DB
Removing FloatToString
warning: Library Git clone folder /home/ubuntu/workspace/gitclones/github.com/koendv/FloatToString not present
Success!

@MatteoPologruto MatteoPologruto merged commit 1d35e0b into arduino:main Feb 21, 2024
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants