Skip to content

add M5Module-GNSS lib #3288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2023
Merged

add M5Module-GNSS lib #3288

merged 3 commits into from
Sep 4, 2023

Conversation

Gitshaoxiang
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: invalid Request could not be processed label Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Hi @Gitshaoxiang
A problem was found with your pull request:

ERROR: Pull request removes newline from the end of a file.
Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 September 4, 2023 02:46
@github-actions github-actions bot added topic: submission Add library to the list and removed topic: invalid Request could not be processed labels Sep 4, 2023
@github-actions github-actions bot removed the request for review from per1234 September 4, 2023 02:48
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

A problem was found with your submission https://github.com/m5stack/M5Module-GNSS

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @Gitshaoxiang
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented Sep 4, 2023

@ArduinoBot please check it again.

@per1234 per1234 self-assigned this Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit 5eb7971 into arduino:main Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/m5stack/M5Module-GNSS/

github-actions bot pushed a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants