Skip to content

Update repositories.txt #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Update repositories.txt #128

merged 1 commit into from
Jun 28, 2021

Conversation

fabianoriccardi
Copy link
Contributor

@fabianoriccardi fabianoriccardi commented Jun 28, 2021

I have changed github username

@github-actions github-actions bot requested a review from per1234 June 28, 2021 17:26
@github-actions
Copy link
Contributor

Hi @fabianoriccardi.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@per1234 per1234 merged commit ab471ea into arduino:main Jun 28, 2021
@per1234
Copy link
Contributor

per1234 commented Jun 29, 2021

Hello @fabianoriccardi. The requested change is now in progress.

Unlike submissions, this type of request is still handled manually. The Library Manager index's maintainer occasionally comes through to clear all the outstanding requests and closes those issues/PRs when that is done. So you can get a notification if you're following the linked issue/PR:
#130

After that, you can monitor the indexing of the library via its logs web page:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@@ -1173,7 +1173,7 @@ https://github.com/fabiopjve/ULWOS2
https://github.com/fabiuz7/Dimmable-Light-Arduino
https://github.com/fabiuz7/esp-logger-lib
https://github.com/fabiuz7/melody-player-arduino
https://github.com/fabiuz7/rtc-memory-esp8266
https://github.com/fabianoriccardi/RTCMemory-ESP8266
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianoriccardi I was about to perform the manual update operations in our crawler, but I saw that the repo now is called
https://github.com/fabianoriccardi/rtcmemory
So I guess it's better to update the PR to use directly the final URL, before I start the manual operations, Can you please update this PR?

In addition, I think it's better also to update your library.properties here
https://github.com/fabianoriccardi/rtcmemory/blob/cc8ddbef5a41f1313d05d9d68768f8cac7276f82/library.properties#L7
to the final github repo link.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use directly the final URL, before I start the manual operations

I agree that is the best thing and have submitted a follow-up PR for that here: #293

I also updated the outstanding PR for the related changes to registry.txt: #130

@rsora rsora added the topic: modification Change existing list entry label Sep 22, 2021
@per1234 per1234 added the topic: URL change Change library repository URL label Apr 29, 2023
@per1234 per1234 removed the topic: URL change Change library repository URL label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants