Skip to content

Update repositories.txt #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lukeclements
Copy link
Contributor

The library.properties file in my repository was incorrect, I have corrected, but am now having issues pushing v1.0.5 to Arduino IDE.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/hsfl/artemis-teensy

ERROR: Submission URL is already in the Library Manager index.

@github-actions github-actions bot added the topic: modification Change existing list entry label Mar 29, 2022
@github-actions
Copy link
Contributor

Hi @lukeclements.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @lukeclements
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 March 29, 2022 19:21
@per1234 per1234 self-assigned this Mar 29, 2022
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Mar 29, 2022
@per1234
Copy link
Contributor

per1234 commented Mar 29, 2022

Hi @lukeclements

Problem

The problem is shown here in the "artemis-teensy" library's dedicated indexer logs web page:

2022/03/29 21:21:41 Checking out tag: v1.0.5
2022/03/29 21:21:41 Release artemis-teensy:1.0.4 already loaded, skipping

Unfortunately, the logs don't communicate about this particular thing very well, but what this tells us is that the version value in the library.properties metadata file was not updated before creating the v1.0.5 tag (note that the indexer checked out tag v1.0.5, only to find the release version was 1.0.4).

You can see it here:

https://github.com/hsfl/artemis-teensy/blob/v1.0.5/library.properties#L2

version=1.0.4

Even though Git tags are the unit of release for the Arduino Library Manager, all versioning is done according to the version field of the library.properties file. For this reason, the indexer will reject any tag that has the same value in its version field as a release already in the index.

Solution

The solution is to make another release of the library which meets the requirements:

  1. Update the version value in library.properties to the version that will be used for the new release.
  2. Create a new release or tag in the library repository.

The indexer system will pick up that new release and it will be available from Library Manager within a day. The non-compliant release will still be missing, but since the newer release will be available, that is no problem.

Since this issue can not be resolved via a pull request here in the arduino/library-registry repository, I'll go ahead and close this. But please feel free to comment here if you have any questions or concerns and I'll help out.

Regards, Per

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants