Distribute release binary in an archive #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release workflow builds the tool and uploads the binary as a release asset. That asset is used by the indexer job and also may be convenient to those who would like to test the release without setting up a build system locally. Previously, the binary was uploaded directly to the release. This caused the executable permissions to be lost, causing inconvenience and potential confusion for the consumers. This can be avoided by packaging the binary in an archive. As an added benefit, the download size is decreased.
per1234
added
type: enhancement
silvanocerza
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflow builds the tool and uploads the binary as a release asset. That asset is used by the indexer job and
also may be convenient to those who would like to test the release without setting up a build system locally.
Previously, the binary was uploaded directly to the release. This caused the executable permissions to be lost, causing
inconvenience and potential confusion for the consumers. This can be avoided by packaging the binary in an archive. As an
added benefit, the download size is decreased.