Add integration tests #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
rsora
reviewed
May 24, 2021
| "LibrariesIndex": working_dir_path.joinpath("libraries", "library_index.json").as_posix(), | ||
| "GitClonesFolder": working_dir_path.joinpath("gitclones").as_posix(), | ||
| # I was unable to get clamdscan working in the GitHub Actions runner, but the tests should pass with this set to | ||
| # False when run on a machine with ClamAV installed. |
There was a problem hiding this comment.
As we were discussing in our chats, being this application something that has to run on a well defined environment, could make sense to include in this repo a Dockerfile with a replica of the destination linux environment, included all the tools that this engine uses (like ClamAV)
rsora
reviewed
May 24, 2021
Comment on lines
+203
to
+204
| if platform.system() == "Windows": | ||
| cd_command += " /d" |
There was a problem hiding this comment.
Same consideration as above, with a container that replicates the production environment we could get rid of this "OS dependant" code
rsora
approved these changes
May 24, 2021
silvanocerza
suggested changes
May 25, 2021
This adds end to end testing of the tool to verify that the finished outputs are as expected.
Co-authored-by: Silvano Cerza <3314350+silvanocerza@users.noreply.github.com>
silvanocerza
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds end to end testing of the tool to verify that the finished outputs are as expected.