Improve order of release processing #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial porting from `github.com/arduino/arduino-modules/git` to `github.com/go-git/go-git` was done with the intention to follow the pre-existing code structure as closely as possible. This resulted in some code duplication. Although minimal, the duplicated code was fairly complex and related to somewhat obscure details of how Git tags work. With work in progress to add even more such complex Git repository handling code, it makes sense to functionalize this previously duplicated code, which also facilitates testing.
Previously, library releases were processed in a lexicographical order. This meant that, for example a 1.0.10 tag was processed before a 1.0.2 tag. In addition to making the logs difficult to read, it's possible this could result in unexpected results in the event multiple library releases had the same library.properties value. The most intuitive sorting order is to follow the order of the commits the tags are associated with in the Git history.
per1234
added
type: enhancement
silvanocerza
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, library releases were processed in a lexicographical order. This meant that, for example a 1.0.10 tag was
processed before a 1.0.2 tag. In addition to making the logs difficult to read, it's possible this could result in
unexpected results in the event multiple library releases had the same library.properties
versionvalue.The most intuitive sorting order is to follow the order of the commits the tags are associated with in the Git history.
You can see an example of the previous behavior here:
https://downloads.arduino.cc/libraries/logs/github.com/arduino-libraries/ArduinoIoTCloud/