Skip to content

Add rules to find incorrectly formatted units #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 14, 2022
Merged

Add rules to find incorrectly formatted units #98

merged 13 commits into from
Apr 14, 2022

Conversation

sebromero
Copy link
Contributor

What Needs To Be Reviewed

  • Please check if the rules detect the wanted patterns.

Some test content could be e.g.

400 MHz
400 Mhz
400Mhz

480 *Mbps*
480Mbps

150 kB
150kB
200 KB

12 MB
12mb-test of ram
14 mB

18 μm
test-18μm-test
18μm

How To Give Feedback

Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏

@sebromero sebromero requested a review from jhansson-ard March 17, 2022 14:52
@sebromero
Copy link
Contributor Author

@martab1994 I've added some linter rules in this PR to issue warnings if inconsistent unit formatting is detected.

@marqdevx marqdevx added the arduino Bugs and fixes added by the Arduino Team label Mar 28, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 30, 2022 •
edited
Loading

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3m

jhansson-ard
jhansson-ard reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some ' ' to better differentiate the 'Megabit per second' compared to the rest of the sentence. Also added this to the other comments. What do you think?

I also updated the Mbps and the Gbps according to our guides.

sebromero and others added 4 commits April 14, 2022 13:21
@sebromero @jhansson-ard
Improve error message
b2e3c0a 
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
@sebromero @jhansson-ard
Improve error message
ddf2db1 
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
@sebromero @jhansson-ard
Improve error message
248bf8c 
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
@sebromero @jhansson-ard
Improve error message
6813963 
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
@sebromero
Copy link
Contributor Author

@jhansson-ard Committed your suggestions. Does it now catch all the desired misspellings?

jhansson-ard
jhansson-ard reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this part creates an issue, I updated it here I think

jhansson-ard
jhansson-ard reviewed Apr 14, 2022
View reviewed changes
@sebromero sebromero merged commit bfbe148 into main Apr 14, 2022
@sebromero sebromero deleted the sebromero/spelling-rules branch April 14, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhansson-ard jhansson-ard jhansson-ard approved these changes

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebromero @jhansson-ard @marqdevx