Skip to content

[PC-1069] Nicla Sense ME - Datasheet Fix #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Jorgetrujilloroman
Copy link
Collaborator

@Jorgetrujilloroman Jorgetrujilloroman commented Apr 4, 2023

What This PR Changes

  • Jira task
  • Adding a table to the "Declaration of Conformity to EU RoHS & REACH 211 01/19/2021" section and small grammatical corrections.
  • Deleting unnecessary datasheet file from the repo (It is generated on the build)

Contribution Guidelines

Adding table to "Declaration of Conformity to EU RoHS & REACH 211 01/19/2021" section and small grammatical corrections.
@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 4, 2023

✅ docs-content deploy preview ready

@jcarolinares
Copy link
Contributor

@Jorgetrujilloroman review done, waiting for changes

Grammatical corrections and page break added to make it look better.
@Jorgetrujilloroman
Copy link
Collaborator Author

@jcarolinares Requested changes are done. Waiting for new review.

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved, pdf format and changes are correct

@Jorgetrujilloroman please merge, thanks :)

@Jorgetrujilloroman
Copy link
Collaborator Author

Merging

@Jorgetrujilloroman Jorgetrujilloroman merged commit d78097b into main Apr 14, 2023
@Jorgetrujilloroman Jorgetrujilloroman deleted the jorgetrujilloroman/nicla-sense-me/datasheet-fix branch April 14, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants