[PC-1069] Portenta X8 - Datasheet Fix #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Portenta X8 Datasheet grammatical corrections and fixing the Index headers and ennumeration.
|
I have a local render of the new version of the Datasheet. I can send it if necessary to compare the changes with the original. @jcarolinares |
❌ docs-content deploy preview failedYour build failed. View the build logs. |
✅ docs-content deploy preview ready
|
jcarolinares
requested changes
Apr 13, 2023
There was a problem hiding this comment.
@Jorgetrujilloroman reviewed please perform the changes and contact me after it.
content/hardware/04.pro/boards/portenta-x8/datasheet/datasheet.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-x8/datasheet/datasheet.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-x8/datasheet/datasheet.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-x8/datasheet/datasheet.md
Outdated
Show resolved
Hide resolved
|
@jcarolinares I applied all your reviewing suggestions. I think it is ready for re-review |
jcarolinares
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Format problems fixed
ready to merge @Jorgetrujilloroman thanks!
|
Merging to main |
Jorgetrujilloroman
deleted the
jorgetrujilloroman/portenta-x8/datasheet-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines