Skip to content

[TC-424] Update Pinout image in MKR IoT Carrier Rev2 DS #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[TC-424] Update Pinout image in MKR IoT Carrier Rev2 DS #774

wants to merge 4 commits into from

Conversation

aliphys
Copy link
Contributor

@aliphys aliphys commented Jan 16, 2023

What This PR Changes

  • Update Pinout.png to latest version
  • Add entry to revision history

Contribution Guidelines

@aliphys aliphys requested a review from jcarolinares January 16, 2023 09:00
@aliphys aliphys mentioned this pull request Jan 16, 2023
Merged
1 task
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jan 16, 2023 •
edited
Loading

✅ docs-content deploy preview ready

@aliphys aliphys changed the title Update Pinout image in MKR IoT Carrier Rev2 Update Pinout image in MKR IoT Carrier Rev2 DS Jan 16, 2023
@aliphys aliphys added Datasheet fix/update A small fix or update labels Jan 16, 2023
@aliphys
Copy link
Contributor Author

aliphys commented Jan 16, 2023

Linter complains that Pinout.png is not accessible. https://github.com/arduino/docs-content/actions/runs/3929003237/jobs/6717278125#step:3:70
However, I can render it locally and generate the PDF datasheet without errors.
image
I can see that the updated file (12 Jan) is on the remote branch as well.
https://github.com/arduino/docs-content/blob/1c2ad8e4bc617a068d93f81c4732bf0f9dd20bc0/content/hardware/01.mkr/03.carriers/mkr-iot-carrier-rev2/datasheet/assets/Pinout.png

@aliphys aliphys changed the title Update Pinout image in MKR IoT Carrier Rev2 DS [TC-424] Update Pinout image in MKR IoT Carrier Rev2 DS Jan 16, 2023
@aliphys
Copy link
Contributor Author

aliphys commented Jan 16, 2023

Going to close this PR and re-open a new one. This is an attempt to fix the linter issue
image
This worked for #740 (comment) so worth a try

@aliphys aliphys closed this Jan 16, 2023
@aliphys aliphys mentioned this pull request Jan 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarolinares jcarolinares Awaiting requested review from jcarolinares

Assignees
No one assigned
Labels
Datasheet fix/update A small fix or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aliphys