Skip to content

LED matrix circuit issues [MKC-555] #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2022
Merged

Conversation

jhansson-ard
Copy link
Contributor

@jhansson-ard jhansson-ard commented Jul 22, 2022

What This PR Changes

  • There were resistors missing in the LED matrix circuit diagram. The resistors keep the matrix from burning, and this PR updates both the circuit diagram and adds a text noting on this.

Original issue: #374

Review: Compare the old and new image with the issue posed in the issue above.

Contribution Guidelines

@jhansson-ard jhansson-ard requested a review from per1234 July 22, 2022 07:23
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 22, 2022

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3m

@jhansson-ard
Copy link
Contributor Author

@per1234 please review to see if you agree with my changes ⭐

@karlsoderby karlsoderby self-requested a review August 2, 2022 12:12
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the text to reflect changes as well. I think it looks good now.

@jhansson-ard jhansson-ard merged commit 85facc3 into main Aug 2, 2022
@jhansson-ard jhansson-ard deleted the jhansson-ard/led-matrix-fix branch August 2, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants