Skip to content

Update memory-guide.md #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Update memory-guide.md #313

merged 1 commit into from
Jun 28, 2022

Conversation

scraprats
Copy link
Contributor

@scraprats scraprats commented Jun 28, 2022 •
edited
Loading

What This PR Changes

In the document the maximum value of char type is off by 1

Contribution Guidelines

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jhansson-ard jhansson-ard added documentation Improvements or additions to documentation fix/update A small fix or update community Bugs and fixes suggested by the community labels Jun 28, 2022
canchebagur
canchebagur approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@canchebagur canchebagur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhansson-ard
Copy link
Contributor

@verypurple thanks for your contribution! Please make sure to update the PR description with your changes, as well as signing the CLA.

When you have signed the CLA, we can merge your change! ⭐

@jhansson-ard jhansson-ard merged commit b5676f4 into arduino:main Jun 28, 2022
TaddyHC
TaddyHC reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@TaddyHC TaddyHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Serjlee pushed a commit that referenced this pull request Mar 1, 2023
@karlsoderby
Merge pull request #313 from arduino/karlsoderby/usb-review
618a57e 
Giga USB changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaddyHC TaddyHC TaddyHC left review comments

@canchebagur canchebagur canchebagur approved these changes

Assignees
No one assigned
Labels
community Bugs and fixes suggested by the community documentation Improvements or additions to documentation fix/update A small fix or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scraprats @CLAassistant @jhansson-ard @canchebagur @TaddyHC