-
-
Notifications
You must be signed in to change notification settings - Fork 443
Add library specification to library tutorial #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR includes a reference to the library specification at the end of the article.
Include library reference in library guide
Add link to the Library Manager FAQ Fix typo
Fixes parts of #236 |
Hi @per1234, You are correct, it does not include that part. I'm somewhat with @matthijskooijman, the tutorial probably should be overhauled in general, although note that the last revision date was the 23rd of May, just a couple of weeks ago. Still, issue #236 open since 2016 and I just happened to run into the very same problem as well, spending half an hour trying to find the right information. |
I completely agree. I only made my previous reply to indicate that we should not necessarily consider #236 100% resolved by this PR. That doesn't mean this PR is required to provide a 100% resolution, only that we should not close #236 if there are still unresolved components. |
Gotcha! I've updated my previous comment to reflect that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gvenzl!
This PR includes a reference to the library specification at the end of the article.
What This PR Changes
Contribution Guidelines