Skip to content

Update i2c.md #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Update i2c.md #276

merged 1 commit into from
Jun 29, 2022

Conversation

nikhilsigma
Copy link
Contributor

Builtin LED is not set as output in Reader (I2C slave) program. Thus the LED is not turning on.
So following line needs to be added.
pinMode(LED_BUILTIN,OUTPUT); // sets onBoard LED as output

What This PR Changes

  • (Please explain here why you created the pull request and specify what it changes)
  • Original code for I2C slave (reader) is not working.

Contribution Guidelines

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2022

CLA assistant check
All committers have signed the CLA.

@jhansson-ard jhansson-ard added fix/update A small fix or update community Bugs and fixes suggested by the community maker labels Jun 14, 2022
Copy link
Contributor

@BenjaminDannegard BenjaminDannegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero
Copy link
Contributor

Hi @nikhilsigma ! Can you sign your Contributor License Agreement so we can merge this PR?

@nikhilsigma
Copy link
Contributor Author

Hi @nikhilsigma ! Can you sign your Contributor License Agreement so we can merge this PR?

Done. I signed CLA.

@jhansson-ard jhansson-ard requested a review from marqdevx June 29, 2022 07:04
Builtin LED is not set as output in Reader (I2C slave) program. Thus the LED is not turning on.
So following line needs to be added.
  pinMode(LED_BUILTIN,OUTPUT);  // sets onBoard LED as output
@marqdevx
Copy link
Member

Fixed conflicts, merging after checks, thanks for the PR!

@marqdevx marqdevx merged commit 349c487 into arduino:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update maker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants