[MKC-1854] GIGA CAN / ADC fixes #2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the CANRX and CANTX pins are not attached to the ADC, and they were incorrectly documented, likely due to previous boards with form factor having these pins as A14/15
karlsoderby
changed the title
Hannes7eicher
added
documentation
Preview Deployment🚀 Preview this PR: https://66fa658020084c4566dad8e9--docs-content.netlify.app |
Hannes7eicher
requested changes
Sep 25, 2024
|
@Hannes7eicher totally agree. Changes fixed! |
Hannes7eicher
approved these changes
Sep 26, 2024
content/hardware/10.mega/boards/giga-r1-wifi/tutorials/cheat-sheet/cheat-sheet.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/boards/giga-r1-wifi/tutorials/cheat-sheet/cheat-sheet.md
Outdated
Show resolved
Hide resolved
…heet/cheat-sheet.md Co-authored-by: Hannes Siebeneicher <60609597+Hannes7eicher@users.noreply.github.com>
…heet/cheat-sheet.md Co-authored-by: Hannes Siebeneicher <60609597+Hannes7eicher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIGA documentation had incorrectly labelled CANTX/CANRX pins (D93/D94) as ADC pins. These pins are not connected to the ADC.
Contribution Guidelines