Skip to content

[MKC-1349] CAN Bus Learn Article #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 23, 2024
Merged

[MKC-1349] CAN Bus Learn Article #2122

merged 5 commits into from
Aug 23, 2024

Conversation

Hannes7eicher
Copy link
Contributor

What This PR Changes

This PR adds a learning article about the CAN bus protocol.

Contribution Guidelines

@Hannes7eicher Hannes7eicher added documentation Improvements or additions to documentation new arduino Bugs and fixes added by the Arduino Team how-to article New How To article maker preview labels Aug 16, 2024
@Hannes7eicher Hannes7eicher changed the title CAN Bus Learn Article [MKC-1349] CAN Bus Learn Article Aug 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

Preview Deployment

🚀 Preview this PR: https://66c72edeb3f6bc10ba2f6e37--docs-content.netlify.app
📍 Commit SHA: e142c41

@Hannes7eicher Hannes7eicher marked this pull request as ready for review August 20, 2024 10:13
pedromsousalima
pedromsousalima requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@pedromsousalima pedromsousalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only vital change is the link to the DUE everything else is sigestions.
Such a fun piece of content!!!

@Hannes7eicher @pedromsousalima
Apply suggestions from code review
3c1c58f 
Co-authored-by: pedromsousalima <32345730+pedromsousalima@users.noreply.github.com>
@pedromsousalima
Copy link
Contributor

LGTM

pedromsousalima
pedromsousalima approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@pedromsousalima pedromsousalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hannes7eicher Hannes7eicher merged commit 38cd82d into main Aug 23, 2024
4 checks passed
@Hannes7eicher Hannes7eicher deleted the hannes7eicher/CAN-Learn-Article branch August 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedromsousalima pedromsousalima pedromsousalima approved these changes

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation how-to article New How To article maker new preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hannes7eicher @pedromsousalima