Skip to content

[PC-1602] Multiple changes on Opta #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Conversation

jcarolinares
Copy link
Contributor

What This PR Changes

  • Multiple changes on Opta to small improvements

Contribution Guidelines

Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-content ✅ Ready (Inspect) Visit Preview Mar 8, 2024 2:52pm

Copy link

github-actions bot commented Mar 8, 2024

docs-content

🚀 Preview this PR: https://ceca6af9.docs-content.pages.dev
📍 Commit SHA: 26ca5ee

@jcarolinares jcarolinares requested review from jhansson-ard and removed request for jhansson-ard March 11, 2024 17:22
@jcarolinares jcarolinares changed the title Multiple changes on Opta [PC-1602] Multiple changes on Opta Mar 11, 2024
@jcarolinares jcarolinares requested a review from TaddyHC March 11, 2024 17:23
Copy link
Contributor

@TaddyHC TaddyHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some few suggestions, other than that, the changes LGTM

jcarolinares and others added 4 commits March 11, 2024 19:37
…-started-with-rs485/content.md

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…-started-with-rs485/content.md

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…-started-with-modbus-rtu/content.md

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
Suggestion from Taddy's review added

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
@jcarolinares jcarolinares merged commit 63ac1c8 into main Mar 11, 2024
@jcarolinares jcarolinares deleted the jcarolinares/opta-improvements branch March 11, 2024 19:05
Matteo-it pushed a commit that referenced this pull request Mar 12, 2024
* Multiple changes on Opta

* Small but important fixes and improvements detected after Docs 2.0 web launch

* Update content/hardware/07.opta/opta-family/opta/tutorials/02.getting-started-with-rs485/content.md

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>

* Update content/hardware/07.opta/opta-family/opta/tutorials/02.getting-started-with-rs485/content.md

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>

* Update content/hardware/07.opta/opta-family/opta/tutorials/03.getting-started-with-modbus-rtu/content.md

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>

* Apply suggestions from code review

Suggestion from Taddy's review added

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>

---------

Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
@jhansson-ard jhansson-ard added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team pro labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update pro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants