Skip to content

[GIGA R1 WiFi] Update RTC/NTP/UDP example. #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

karlsoderby
Copy link
Contributor

What This PR Changes

  • Updates teh RTC/NTP/UDP examples

Contribution Guidelines

Copy link

github-actions bot commented Jan 29, 2024

docs-content

🚀 Preview this PR: https://e4243e0c.docs-content.pages.dev
📍 Commit SHA: 601d930

Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a line missing in the example you added, the sketch doesn't compile

/private/var/folders/47/fzd1lv495hj44d_nk71x3hbc0000gn/T/.arduinoIDE-unsaved2024029-1092-1c0l5c7.r6ts/sketch_jan29a/sketch_jan29a.ino: In function 'long unsigned int parseNtpPacket()':
/private/var/folders/47/fzd1lv495hj44d_nk71x3hbc0000gn/T/.arduinoIDE-unsaved2024029-1092-1c0l5c7.r6ts/sketch_jan29a/sketch_jan29a.ino:126:3: error: 'new_epoch' was not declared in this scope
   new_epoch = epoch + (3600 * timezone); //multiply the timezone with 3600 (1 hour)

@jhansson-ard jhansson-ard added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team maker labels Jan 29, 2024
@karlsoderby
Copy link
Contributor Author

Thanks @jacobhylen , fixed now! 👍

Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now :)

@karlsoderby karlsoderby merged commit f5c782b into main Jan 30, 2024
@karlsoderby karlsoderby deleted the karlsoderby/giga-cs-rtc-ntp branch January 30, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update maker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants