-
-
Notifications
You must be signed in to change notification settings - Fork 440
[MKC-1351] OPAMP Docs #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MKC-1351] OPAMP Docs #1596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of things that need changing before we go live, but it's a good start.
Apart from the other comments I left, there are a few things I feel are missing.
- This shows how to set it up for a 2x amplification, but where is this configured? Can i amplify by another factor?
- comparator functionality, we say it can be used for this but never show how
- If I follow the article, there aren't really any loose ends to grasp at, I am left with an incomplete project and am asking myself what to explore next?
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/assets/circuitAmplifier.png
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/assets/circuitFollower.png
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/assets/circuitFollower.png
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/assets/circuitFollower.png
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-minima/tutorials/opamp/assets/circuitAmplifier.png
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
Also we should warn not to amplify a battery, as you'd essentially short circuit it. Depending on the battery this could be dangerous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better shape, I left a few more comments (sorry, nitpicking), and then we're good to go.
content/hardware/02.hero/boards/uno-r4-minima/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-minima/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-minima/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/opamp/opamp.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Hylén <60390259+jacobhylen@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What This PR Changes
This PR adds documentation on how to use the OPAMP on the Arduino UNO R4 Minima and R4 WiFi.
Contribution Guidelines