Skip to content

[MKC-1351] OPAMP Docs #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 19, 2023
Merged

[MKC-1351] OPAMP Docs #1596

merged 8 commits into from
Dec 19, 2023

Conversation

Hannes7eicher
Copy link
Contributor

What This PR Changes

This PR adds documentation on how to use the OPAMP on the Arduino UNO R4 Minima and R4 WiFi.

Contribution Guidelines

@Hannes7eicher Hannes7eicher added documentation Improvements or additions to documentation Tutorial arduino Bugs and fixes added by the Arduino Team maker labels Dec 12, 2023
Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things that need changing before we go live, but it's a good start.

Apart from the other comments I left, there are a few things I feel are missing.

  • This shows how to set it up for a 2x amplification, but where is this configured? Can i amplify by another factor?
  • comparator functionality, we say it can be used for this but never show how
  • If I follow the article, there aren't really any loose ends to grasp at, I am left with an incomplete project and am asking myself what to explore next?

@jacobhylen
Copy link
Contributor

Also we should warn not to amplify a battery, as you'd essentially short circuit it. Depending on the battery this could be dangerous.

Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better shape, I left a few more comments (sorry, nitpicking), and then we're good to go.

Co-authored-by: Jacob Hylén <60390259+jacobhylen@users.noreply.github.com>
Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hannes7eicher Hannes7eicher merged commit 4c19a13 into main Dec 19, 2023
@Hannes7eicher Hannes7eicher deleted the Hannes7eicher/OPAMP branch December 19, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation maker Tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants