Fix: In MKR Relay Shield AREF and A0 are mistakenly noted as SDA and SCL respectively.
#1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliphys
added
documentation
✅ docs-content deploy preview ready
|
karlsoderby
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Hey @aliphys , looks great but a very very small design change is needed, which are the rounded corners when it is an ending label.
I already made the change in Figma, but can you export and update the images?
karlsoderby
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
AREFandA0are mistakenly noted asSDAandSCLrespectively.SDAandSCLare on pinsD11andD12respectively. This is not modified.Contribution Guidelines