Skip to content

[MKC-1222] Update servo illustrations #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

Hannes7eicher
Copy link
Contributor

What This PR Changes

This PR fixes the illustrations for the servo example on the learn page.

Contribution Guidelines

@Hannes7eicher Hannes7eicher added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team maker labels Oct 3, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 3, 2023

✅ docs-content deploy preview ready

Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hannes7eicher left a couple of suggestions.

Just one confusing part:

  • So the circuit is connected to D3 (~), the label says D2, the text says D9, and the code says D9. So they need to be updated to be all matching.

@karlsoderby karlsoderby self-requested a review October 5, 2023 09:10
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now @Hannes7eicher !

@Hannes7eicher Hannes7eicher merged commit 0f76c4f into main Oct 5, 2023
@Hannes7eicher Hannes7eicher deleted the Hannes7eicher/Servo-Fix branch October 5, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update maker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants