Skip to content

[PC-1230] Update ESLOV information in Nicla Voice datasheet #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2023

Conversation

canchebagur
Copy link
Contributor

What This PR Changes

  • This PR updates the ESLOV connector information in the Nicla Voice datasheet.

Contribution Guidelines

@canchebagur canchebagur requested a review from jcarolinares May 12, 2023 06:59
@canchebagur canchebagur self-assigned this May 12, 2023
@canchebagur canchebagur added Datasheet fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team pro labels May 12, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented May 12, 2023

✅ docs-content deploy preview ready

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perform the small changes and ready to merge.

canchebagur and others added 4 commits May 12, 2023 07:57
…et.md

Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
…et.md

Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
…et.md

Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
@canchebagur
Copy link
Contributor Author

@jcarolinares PDF file updated with the latest changes.

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@canchebagur forgot to say:

we have to remove the PDF file, if not the server will put that file instead of rendering one based on the datasheet.md, please do!

@canchebagur
Copy link
Contributor Author

@jcarolinares done!

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merging

@jcarolinares jcarolinares merged commit 685f35c into main May 15, 2023
@jcarolinares jcarolinares deleted the canchebagur/nicla-voice-eslov-connector branch May 15, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team Datasheet fix/update A small fix or update pro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants