Skip to content

Include executable file and license inside a directory during release #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Dec 5, 2022

Previously, the release system generated archives without a root folder:

$ wget https://downloads.arduino.cc/tools/arduinoOTA/arduinoOTA_1.4.0_macOS_64bit.tar.gz

[...]

$ tar -t -f arduinoOTA_1.4.0_macOS_64bit.tar.gz 

arduinoOTA
LICENSE.txt

Arduino Boards Manager requires tool dependency archives to contain a root folder, so the lack of one caused installations of dependent platforms to fail:

Downloading packages
arduino:arduinoOTA@1.4.0
arduino:megaavr@1.8.8
Installing arduino:arduinoOTA@1.4.0
Failed to install platform: arduino:megaavr.
Error: 13 INTERNAL: Cannot install tool arduino:arduinoOTA@1.4.0: searching package root dir: files in archive must be placed in a subdirectory

The changes proposed here will result in release archives which do contain the required root folder:

$ tar -t -f arduinoOTA_8.8.8_macOS_64bit.tar.gz 

arduinoOTA_osx_darwin_amd64/
arduinoOTA_osx_darwin_amd64/arduinoOTA
arduinoOTA_osx_darwin_amd64/LICENSE.txt

Test release: https://github.com/MatteoPologruto/arduinoOTA/releases/tag/8.8.8

@MatteoPologruto MatteoPologruto added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Dec 5, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 5, 2022
@MatteoPologruto MatteoPologruto merged commit 22a8958 into arduino:master Dec 5, 2022
@MatteoPologruto MatteoPologruto deleted the release-fix branch December 5, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants