Remove "All" check mode #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mode was an initial unsuccessful attempt at achieving what was later done by the "Default" check mode. The "All" check mode is no longer necessary. It can have a harmful effect when used in place of "Default" because it makes the behavior of the check configuration dependent on the order the check configuration fields are processed in, which is confusing and not guarantee to remain the same. The "Default" check mode is always overridden by an explicit check mode match, so it's behavior is well defined and intuitive.
The enable/disable configuration of each check must be configured for every check mode. The level configuration of each check must be configured for every check mode the check is enabled for.
The check was also misconfigured as a warning in check modes where it should be an error, which has been corrected as well.
In addition to being pointless, having the same check mode in multiple companion configuration fields results in the configuration behavior being dependent on which order the fields are processed in, which may change.
silvanocerza
reviewed
Dec 3, 2020
silvanocerza
approved these changes
Dec 3, 2020
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.