Handle library load failures #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
force-pushed
the
per1234/handle-library-load-failures
branch
from
1de68fe to
b1c0d98
Compare
silvanocerza
approved these changes
Dec 2, 2020
Since the properties package has a function supporting the paths.Path type the library.properties path starts in, it was silly to convert it to a string for use with properties.Load().
In the event of a problem loading, this will return an empty map rather than nil. The error already serves as the indicator of this problem for the invalid library.properties check, so having an empty map as the output only simplifies the handling of that situation in the other checks.
The issue that caused the failure will be caught by a specific check, so the other checks that use the data returned by this function should simply not run.
per1234
force-pushed
the
per1234/handle-library-load-failures
branch
from
b1c0d98 to
98d8011
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.