Fix subproject discovery #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Dec 1, 2020
Previously, the subprojects parent folder was searched for subprojects. Due to the recursive search setting, that still found library example sketches (after unnecessarily checking the examples folder itself for a sketch). However, the subproject search of platform bundled libraries is not recursive (because the libraries must be directly under the libraries folder), meaning these subprojects were not discovered.
Previously, project.findProjectsUnderPath() searched for projects and subprojects under the given path. The problem with this is that project.findSubprojects() uses project.findProjectsUnderPath() to detect subprojects, which resulted in subproject duplicates. Making the project and subproject discovery distinct steps fixes this and also makes the code easier to follow.
Although not a problem for normal usage, the previous behavior of appending target paths on each call to configuration.Initialize() interfered with the ability to use this function in multiple tests.
per1234
force-pushed
the
per1234/fix-subproject-discovery
branch
from
fac4e74 to
ba5c3cb
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.