Reconfigure taskfile to avoid global golint dependency #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach for defining the `GOLINTBIN` variable caused any use of task to fail if golint was not installed, even though the task being run might have nothing to do with golint.
silvanocerza
approved these changes
Oct 27, 2020
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach for defining the
GOLINTBINvariable caused any use of task to fail ifgolintwas not installed, even though the task being run might have nothing to do withgolint.There are multiple alternative fixes for this, but since the
GOLINTBINvariable was only used in a single task, and I don't foresee it being needed in additional tasks, it seemed easiest to just do away with the variable altogether.