Run Go module configuration sync check also on docsgen module #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
silvanocerza
reviewed
Aug 4, 2021
silvanocerza
approved these changes
Aug 4, 2021
The `check-config` job of the "Check Go" workflow runs a check to see whether there were any missed updates to the `go.mod` and `go.sum` files. Previously, this was only done for the main module. But there is an additional module for generating the website's command reference content the update of which might easily be overlooked. The CI check was not applied to this module, which could allow its metadata to get out of date. The use of a job matrix allows the workflow to easily accomodate the future addition of more modules to the repository by simply adding their path to the matrix array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check-configjob of the "Check Go" workflow runs a check to see whether there were any missed updates to thego.modandgo.sumfiles. Previously, this was only done for the main module. But there is an additional module forgenerating the website's command reference content the update of which might easily be overlooked. The CI check was not
applied to this module, which could allow its metadata to get out of date.
The use of a job matrix allows the workflow to easily accomodate the future addition of more modules to the repository by
simply adding their path to the matrix array.