Skip to content

Use "rule" term instead of "check" #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Use "rule" term instead of "check" #125

merged 4 commits into from
Dec 21, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Dec 21, 2020

The term "rule" is more appropriate.

This package is more closely related to the projects than the checks.

The schema folder was left in place because it is an implementation of the checks, so most appropriate where it was.
The purpose of this package is collecting the data on a project, so "projectdata" is a more appropriate name.
The previous function name was redundant.
The term "rule" is more appropriate.
@per1234 per1234 requested a review from rsora December 21, 2020 11:58
@per1234
Copy link
Contributor Author

per1234 commented Dec 21, 2020

The "Check documentation links" workflow failure is expected. It's caused by the repositories being private.

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit that I trusted the tests for this one 😸

@per1234 per1234 merged commit 439c93d into main Dec 21, 2020
@per1234 per1234 deleted the per1234/check-to-rule branch December 21, 2020 14:44
@per1234 per1234 added topic: code Related to content of the project itself topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants