Add SuperprojectType field to check configuration #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "Check documentation links" workflow failure is expected. It's caused by the repositories being private. |
rsora
approved these changes
Dec 21, 2020
This change adds the possibility to use projecttype.All in check configurations.
In some cases, the context of the project is relevant to the check configuration. Previously, this was dealt with by the code of the check function, but it seems more logical to handle it in the check configuration, since that is already being done there with the project type.
The newly added field allows moving the implementation of this filter out of the check function and into the check configuration. It also allows some simplification of the check function tests.
In the case of official platform bundled libraries, it doesn't make sense to req uire the Arduino_ prefix since equivalent platform bundled libraries are often provided by each platform, both official and 3rd party. The "namespace" provided by the prefix is only needed in the context of standalone libraries. In the case of platform bundled libraries, the platform can provide the branding.
These checks are irrelevant for bundled libraries.
Library Manager-specific checks are irrelevant for platform bundled libraries, and so should be skipped for those projects.
per1234
force-pushed
the
per1234/superproject-checkconfiguration-field
branch
from
e5ad1d1 to
5c621be
Compare
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the context of the project is relevant to the check configuration. Previously, this was dealt with by the
code of the check function, but it seems more logical to handle it in the check configuration, since that is already
being done there with the project type.