Unable to write tests for schema-based check functions

[per1234]

The schemas themselves and the schema handling functions have pretty good coverage, but I'm still missing the ability to add tests for the check functions based on them, For example:

arduino-lint/check/checkfunctions/library.go

Lines 119 to 134 in f22ed88

	// LibraryPropertiesNameFieldLTMinLength checks if the library.properties "name" value is less than the minimum length.
	func LibraryPropertiesNameFieldLTMinLength() (result checkresult.Type, output string) {
	if checkdata.LibraryPropertiesLoadError() != nil {
	return checkresult.NotRun, "Couldn't load library.properties"
	}
	if !checkdata.LibraryProperties().ContainsKey("name") {
	return checkresult.NotRun, "Field not present"
	}
	if schema.PropertyLessThanMinLength("name", checkdata.LibraryPropertiesSchemaValidationResult()[compliancelevel.Specification], configuration.SchemasPath()) {
	return checkresult.Fail, ""
	}
	return checkresult.Pass, ""
	}

I haven't figured out how to do this.

This is related to the previous discussion here:
#14 (review)

The trouble is that the schema path is configured relative to the executable path (#21):

arduino-lint/configuration/configuration.go

Line 210 in f22ed88

executablePath, err := os.Executable()

which doesn't work when running tests.

The tests I have written for functions using the schemas were possible because they had a schema path parameter. But the check functions don't have such a parameter and I don't like the idea of adding such a parameter to every check function.

[per1234]

@silvanocerza any ideas?

[silvanocerza]

First thing that comes to mind would be to embed the schemas directly into the code, so it's all contained in the final binary.
This would also ease the release process since we won't have to release the json files together with the final executable.

With Go 1.16 they should introduce a way to embed resource files using a new directive but there's still for some time before they release it.

Otherwise we could use the library go-bindata.

I found this info in this StackOverflow question, I suggest you give it a read, there are some interesting points in this answer.

Otherwise we could simply put the whole jsons in literal strings inside the code, that would make it harder to edit the schemas probably.