Skip to content

ucloud: Allow passing device id, username and password as strings. #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ Your `secrets.py` file should look like this:
```python
WIFI_SSID = "" # WiFi network SSID (for MicroPython)
WIFI_PASS = "" # WiFi network key (for MicroPython)
DEVICE_ID = b"" # Provided by Arduino cloud when creating a device.
SECRET_KEY = b"" # Provided by Arduino cloud when creating a device.
DEVICE_ID = "" # Provided by Arduino cloud when creating a device.
SECRET_KEY = "" # Provided by Arduino cloud when creating a device.
```

For more detailed examples and advanced API features, please see the [examples](https://github.com/arduino/arduino-iot-cloud-py/tree/main/examples).
Expand Down
11 changes: 10 additions & 1 deletion src/arduino_iot_cloud/ucloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,19 @@ def __init__(
self.thing_id = None
self.keepalive = keepalive
self.last_ping = timestamp()
self.device_topic = b"/a/d/" + device_id + b"/e/i"
self.senmlpack = SenmlPack("", self.senml_generic_callback)
self.started = False

# Convert args to bytes if they are passed as strings.
if isinstance(device_id, str):
device_id = bytes(device_id, "utf-8")
if username is not None and isinstance(username, str):
username = bytes(username, "utf-8")
if password is not None and isinstance(password, str):
password = bytes(password, "utf-8")

self.device_topic = b"/a/d/" + device_id + b"/e/i"

# Update RTC from NTP server on MicroPython.
self.update_systime(ntp_server, ntp_timeout)

Expand Down