Skip to content

The Windows build is broken for external contributors #2545

Closed
@dankeboy36

Description

@dankeboy36

Describe the problem

Originally from #2543 (comment):

The build failure is most likely unrelated to the proposed changes; the CI must not sign the builds from forks:

Custom windows signing was no performed one of the following variables was not provided: SIGNTOOL_PATH (C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe), INSTALLER_CERT_WINDOWS_CERT (C:/Users/Utente/AppData/Local/Temp/cert.cer), CERT_PASSWORD (), CONTAINER_NAME ()

I recognize that the team is small and that code reviews do not receive enough attention from maintainers. However, this CI error effectively blocks collaboration on the project.

To reproduce

Open a PR from a fork. The PR must include code changes. For example, changing markdown files won't trigger an electron build. See #2543 as an example.

Expected behavior

The Windows signing does not run on PRs opened from forks.

Or

The Windows signing works.

Arduino IDE version

3ccc864

Operating system

Windows

Operating system version

It's a CI

Additional context

Breaking change: 2e78e96.

CIs are smart to mask secrets, but I would probably remove the password printing to the console when not all envs are truthy.

`Custom windows signing was no performed one of the following variables was not provided: SIGNTOOL_PATH (${SIGNTOOL_PATH}), INSTALLER_CERT_WINDOWS_CERT (${INSTALLER_CERT_WINDOWS_CER}), CERT_PASSWORD (${CERT_PASSWORD}), CONTAINER_NAME (${CONTAINER_NAME})`

There is a typo in the console log.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions