Skip to content

Tab selection partially lost on rename #219

Open
@per1234

Description

@per1234

Describe the bug

🐛 When a tab is renamed, the adjacent one is functionally selected, even though the renamed one is visually selected.

To Reproduce

  1. Click the downward pointing triangle button on the right side of the tab bar.
  2. Click "New Tab"
  3. In the "Name for new file" dialog, type foo.h
  4. Click the OK button.
  5. Click the downward pointing triangle button on the right side of the tab bar.
  6. Click "New Tab"
  7. In the "Name for new file" dialog, type bar
  8. Click the OK button.
  9. Click the downward pointing triangle button on the right side of the tab bar.
  10. Click "Rename"
  11. In the "Name for new file" dialog, type baz
  12. Click the OK button.
    🐛 Note that the window title now shows that the "foo.h" is selected, but the GUI shows that "baz.ino" is selected.
  13. Press Ctrl+F
    🐛 Note that the "Find" GUI does not appear
  14. Click on the "foo.h" tab.
    🐛 Note that the top and bottom of the "Find" GUI are missing:
    Clipboard01

Expected behavior

The renamed tab to remain fully selected.

Desktop

  • OS: Windows 10
  • Version: 2.0.0-beta.3-nightly.20210313
    Date: 2021-03-13T03:11:23.309Z
    CLI Version: 0.16.1 alpha [76f55490]

Additional context

The addition of the "foo.h" tab is not required. I added that step to the demo because the window title only shows file names when a non-.ino file is selected, so the demonstration is not so clear with a sketch that only contains .ino files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    criticality: mediumOf moderate impacttopic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions